Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RULE-22-3 test #222

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix RULE-22-3 test #222

merged 2 commits into from
Mar 2, 2023

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Mar 2, 2023

Description

Fix compilation issue with test for RULE-22-3

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

馃毃馃毃馃毃
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

馃 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

馃挕 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
PACKAGE              : IO3
TEST_PASS            : True
RULE                 : RULE-22-3
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : FileOpenForReadAndWriteOnDifferentStreams


@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : IO3
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
QUERY                : FileOpenForReadAndWriteOnDifferentStreams
RULE                 : RULE-22-3
COMPILE_PASS         : True
TEST_PASS            : True


@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@mbaluda mbaluda marked this pull request as ready for review March 2, 2023 22:20
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

馃 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

馃挕 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : FileOpenForReadAndWriteOnDifferentStreams
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : RULE-22-3
PACKAGE              : IO3
TEST_PASS            : True
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 


@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
SUITE                : MISRA-C-2012
RULE                 : RULE-22-3
QUERY                : FileOpenForReadAndWriteOnDifferentStreams
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
PACKAGE              : IO3
TEST_DIFFERENCE      : 


@jsinglet
Copy link
Contributor

jsinglet commented Mar 2, 2023

馃 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

@lcartey lcartey merged commit dc310b9 into github:main Mar 2, 2023
@mbaluda mbaluda deleted the mbaluda-22-3-test branch March 3, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants