Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues #240

jsinglet · 2023-03-06T22:22:59Z

Description

Fixes:

1224
1150
1223
1151

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- CON40-C
- CON41-C

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

github-actions · 2023-03-06T22:23:17Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-06T22:24:35Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-06T22:24:39Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-06T22:25:17Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
PACKAGE              : Concurrency5
QUERY                : AtomicVariableTwiceInExpression
TEST_PASS            : True
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : CON40-C
COMPILE_PASS         : True

COMPILE_ERROR_OUTPUT : 
PACKAGE              : Concurrency3
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
TEST_PASS            : True
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : CON41-C
COMPILE_PASS         : True

jsinglet · 2023-03-06T22:25:21Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
PACKAGE              : Concurrency5
SUITE                : CERT-C
TEST_PASS            : True
RULE                 : CON40-C
QUERY                : AtomicVariableTwiceInExpression
TEST_DIFFERENCE      : 

COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
PACKAGE              : Concurrency3
SUITE                : CERT-C
TEST_PASS            : True
RULE                 : CON41-C
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
TEST_DIFFERENCE      :

jsinglet · 2023-03-06T22:25:32Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-06T22:26:04Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-06T22:27:22Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-06T22:27:30Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-06T22:27:56Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
TEST_PASS            : True
QUERY                : AtomicVariableTwiceInExpression
TEST_DIFFERENCE      : 
RULE                 : CON40-C
PACKAGE              : Concurrency5

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
TEST_PASS            : True
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
TEST_DIFFERENCE      : 
RULE                 : CON41-C
PACKAGE              : Concurrency3

jsinglet · 2023-03-06T22:27:56Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
SUITE                : CERT-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
RULE                 : CON40-C
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Concurrency5
QUERY                : AtomicVariableTwiceInExpression

TEST_PASS            : True
SUITE                : CERT-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
RULE                 : CON41-C
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Concurrency3
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop

jsinglet · 2023-03-06T22:28:11Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-07T14:30:17Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-07T14:31:48Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T14:34:21Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T14:34:27Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
PACKAGE              : Concurrency5
COMPILE_PASS         : True
SUITE                : CERT-C
QUERY                : AtomicVariableTwiceInExpression
RULE                 : CON40-C
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 

TEST_PASS            : True
PACKAGE              : Concurrency3
COMPILE_PASS         : True
SUITE                : CERT-C
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
RULE                 : CON41-C
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-07T14:34:47Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
SUITE                : CERT-C
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
QUERY                : AtomicVariableTwiceInExpression
PACKAGE              : Concurrency5
RULE                 : CON40-C
COMPILE_ERROR_OUTPUT : 

TEST_PASS            : True
SUITE                : CERT-C
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
PACKAGE              : Concurrency3
RULE                 : CON41-C
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-07T14:35:11Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

mbaluda

LGTM

github-actions · 2023-03-07T15:51:11Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-07T15:53:13Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


SUITE                : CERT-C
TEST_PASS            : True
PACKAGE              : Concurrency5
RULE                 : CON40-C
TEST_DIFFERENCE      : 
QUERY                : AtomicVariableTwiceInExpression
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 

SUITE                : CERT-C
TEST_PASS            : True
PACKAGE              : Concurrency3
RULE                 : CON41-C
TEST_DIFFERENCE      : 
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-07T15:54:09Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T15:54:10Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T15:54:43Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : AtomicVariableTwiceInExpression
TEST_PASS            : True
PACKAGE              : Concurrency5
SUITE                : CERT-C
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : CON40-C

QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
TEST_PASS            : True
PACKAGE              : Concurrency3
SUITE                : CERT-C
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : CON41-C

jsinglet · 2023-03-07T15:55:08Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-08T12:58:42Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-08T13:00:03Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-08T13:00:39Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
SUITE                : CERT-C
PACKAGE              : Concurrency5
COMPILE_PASS         : True
TEST_PASS            : True
QUERY                : AtomicVariableTwiceInExpression
COMPILE_ERROR_OUTPUT : 
RULE                 : CON40-C

TEST_DIFFERENCE      : 
SUITE                : CERT-C
PACKAGE              : Concurrency3
COMPILE_PASS         : True
TEST_PASS            : True
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
COMPILE_ERROR_OUTPUT : 
RULE                 : CON41-C

jsinglet · 2023-03-08T13:00:42Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : AtomicVariableTwiceInExpression
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : CON40-C
PACKAGE              : Concurrency5
TEST_PASS            : True

COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
QUERY                : WrapFunctionsThatCanFailSpuriouslyInLoop
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : CON41-C
PACKAGE              : Concurrency3
TEST_PASS            : True

jsinglet · 2023-03-08T13:01:58Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-08T13:02:10Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet added 4 commits March 6, 2023 16:52

fix test cases

a3f17fd

fixes

51d0269

compiler compatability

1fa4bba

new library stubs

c5c7972

changelog

7e3dc0b

file missing

7a7ff31

jsinglet changed the title ~~Fixs for #1224, 1150, 1223, 1151 compiler compatibility issues~~ Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues Mar 7, 2023

mbaluda approved these changes Mar 7, 2023

View reviewed changes

Merge branch 'main' into jsinglet/1224-1150-1223-1151

34fa59e

jsinglet enabled auto-merge March 7, 2023 16:03

jsinglet added this pull request to the merge queue Mar 7, 2023

Merge branch 'main' into jsinglet/1224-1150-1223-1151

151930c

lcartey enabled auto-merge March 8, 2023 12:58

lcartey merged commit f1c2ebd into main Mar 8, 2023

lcartey deleted the jsinglet/1224-1150-1223-1151 branch March 8, 2023 13:45

nicolaswill mentioned this pull request Jan 25, 2024

Missing attestations: @mbaluda #505

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues #240

Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues #240

jsinglet commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

github-actions bot commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

mbaluda left a comment

github-actions bot commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

github-actions bot commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues #240

Fixes for #1224, 1150, 1223, 1151 compiler compatibility issues #240

Conversation

jsinglet commented Mar 6, 2023

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

github-actions bot commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

github-actions bot commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

jsinglet commented Mar 6, 2023

github-actions bot commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

mbaluda left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

jsinglet commented Mar 7, 2023

github-actions bot commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023

jsinglet commented Mar 8, 2023