Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive #7238

Closed
SgtSilvio opened this issue Nov 25, 2021 · 3 comments
Closed

LGTM.com - false positive #7238

SgtSilvio opened this issue Nov 25, 2021 · 3 comments
Labels
false-positive Java

Comments

@SgtSilvio
Copy link

Description of the false positive

Getting some java/constant-comparison false positives with char types.
It seems that chars are interpreted as ints.
The same code did not show these warning a while back.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/hivemq/hivemq-mqtt-client/snapshot/8690e4a99ed4eb8366fe8782189fb21c780b5031/files/src/main/java/com/hivemq/client/internal/mqtt/datatypes/MqttUtf8StringImpl.java?sort=name&dir=ASC&mode=heatmap#xd62db7a479f7dea4:1
@MathiasVP MathiasVP added the Java label Nov 25, 2021
@MathiasVP
Copy link
Contributor

Hi @SgtSilvio,

Thanks for reporting this. It should be fixed by #7239.

Note that it can take a couple of weeks for the fix to reach LGTM.

@SgtSilvio
Copy link
Author

Hi @MathiasVP
Thanks for the quick reply and fast fix.
Looking forward to see it fixed on LGTM.

@SgtSilvio
Copy link
Author

seems like it has been solved on LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Java
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MathiasVP @SgtSilvio