Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make autoclose optional #37

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

SamirMarin
Copy link
Contributor

The new feature to close the combined PRs after the combine PR is merged, by adding the Closes prefix is great, but it breaks our workflow slightly because closing the PRs does not delete the branches associated with the PR.

I was hoping to make the option to autoclose optional, since we already have a workflow to take care of closing the PRs and delete the associated branches - the default functionality would still be to autoclose, but if someone wants to disable it they can by passautoclose: false.

@GrantBirki GrantBirki merged commit 62a5e4d into github:main Nov 1, 2023
0 of 3 checks passed
@GrantBirki GrantBirki mentioned this pull request Nov 1, 2023
@SamirMarin SamirMarin deleted the optional-autoclose branch November 8, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants