Merge pull request #30 from jcfr/support-allowlist-for-both-issue-and-pr

fix: Ensure allowlist is also checked in the context of issue

__tests__/functions/prechecks.test.js

@@ -986,6 +986,22 @@ test('runs prechecks and finds that the user is not an allowed operator', async
     message: `### ⚠️ Cannot proceed with operation\n\n> User monalisa is not an allowed operator`,
     status: false
   })
+
+  expect(
+    await prechecks(
+      '123',
+      true,
+      false, // skip_ci
+      true, // skip_reviews
+      false, // allow_drafts
+      'issue', // contextType
+      context,
+      octokit
+    )
+  ).toStrictEqual({
+    message: `### ⚠️ Cannot proceed with operation\n\n> User monalisa is not an allowed operator`,
+    status: false
+  })
 })
 
 test('runs prechecks and finds that skip_ci is set and no reviews are defined', async () => {

src/functions/prechecks.js

@@ -32,6 +32,12 @@ export async function prechecks(
     return {message: validPermissionsRes, status: false}
   }
 
+  // Get allowed operator data
+  if (!(await isAllowed(context))) {
+    message = `### ⚠️ Cannot proceed with operation\n\n> User ${context.actor} is not an allowed operator`
+    return {message: message, status: false}
+  }
+
   // if this is an issue comment, we can skip all the logic below here as it...
   // ... only applies to pull requests
   if (contextType === 'issue') {
@@ -189,12 +195,6 @@ export async function prechecks(
     }
   }
 
-  // Get allowed operator data
-  if (!(await isAllowed(context))) {
-    message = `### ⚠️ Cannot proceed with operation\n\n> User ${context.actor} is not an allowed operator`
-    return {message: message, status: false}
-  }
-
   // log values for debugging
   core.debug('precheck values for debugging:')
   core.debug(`reviewDecision: ${reviewDecision}`)