Added dependabotApiUrl to ENV variable for Proxy Container #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The https://github.com/github/dependabot-api/blob/58b6b17fc41f334c614a1e13cced292219f926e6/app/actions/run_updater/actions.rb#L56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request primarily introduces changes to the
ProxyBuilderclass and its usage in the__tests__/proxy-integration.test.tsandsrc/updater.tsfiles. The changes involve the addition of a new parameterdependabotApiUrlto therunmethod of theProxyBuilderclass and the subsequent adjustments in the method calls throughout the codebase.This is done to provide
dependabotApiUrlas an ENV variable for the proxy container so that thedependabotApiUrlcan be used by newly introduced metrics_client in PR to send metrics from proxy to Dependabot-api.What are you trying to accomplish?
Currently, in AWS each ec2 host (uj-worker-firecracker) runs a datadog agent. The credentials are sourced from secret manager. All update jobs that run in firecracker on the ec2 host will share the same datadog agent for reporting.
After moving to Dependabot on actions, we'd need to run a datadog agent per job which could dramatically affect our datadog billing. Also if we would need to provide the datadog credentials as inputs to the dynamic workflow which increases risk they can be extracted by unsafe code or customers on self-hosted runners. This has already been flagged by the security team.