Fix image cleanup to handle images with tag + digest #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctofu
force-pushed
the
mctofu/fix-cleanup
branch
from
d3266c6
to
9eb4a4f
Compare
mctofu
force-pushed
the
mctofu/fix-cleanup
branch
from
9eb4a4f
to
a292cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started pinning the Docker images via tag & sha in #375.
However, the cleanup process wasn't prepared for this and was no longer able to detect which image was the current one. It was expecting to match the current image name (image + tag + sha) with the list of digests returned by Docker (image + sha). That results in all the images being deleted on each run.
This process adjusts the cleanup process to extract an image name without the tag so we'll be able to match the current image against the
Docker.Imageinfo.RepoDigestslist.