Add test for CredentialFetchingError #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure to retrieve credentials because of a bad API response raises a CredentialFetchingError which has different error handling. The automatic mocking from jest.mock(../src/api-client) as interfering with the instanceof checks in the error handler so I've removed it and replaced with mocks on individual api-client methods. I tried to use a custom mock factory as an alternative but it was much more complex and I couldn't get a working solution that worked with the error handlers and allowed spying on the ApiClient.prototype.
abdulapopoola
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #898 I ran into issues testing the handling of errors from the
api-clientmodule inmain.ts. This fixes the mocking related issues around that and adds an additional test for the existing behavior using theCredentialFetchingErrorfromapi-clientFailure to retrieve credentials because of a bad API response raises a CredentialFetchingError which has different error handling.
The automatic mocking from
jest.mock(../src/api-client)was interfering with theinstanceofchecks in the error handler so I've removed it and replaced with mocks on individual api-client methods. I tried to use a custom mock factory as an alternative but it was much more complex and I couldn't get a working solution that worked with the error handlers and allowed spying on theApiClient.prototype.