Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[From Zendesk] Squash and merge mention in commit signing article now incorrect #11081

Closed
docs-bot opened this issue Oct 11, 2021 · 0 comments · Fixed by #11473
Closed

[From Zendesk] Squash and merge mention in commit signing article now incorrect #11081

docs-bot opened this issue Oct 11, 2021 · 0 comments · Fixed by #11473
Labels
help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@docs-bot
Copy link
Collaborator

Issue overview

We now sign commits that are created via squashing a merging a pull request: https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/

GitHub will automatically use GPG to sign commits you make using the GitHub web interface, except for when you squash and merge a pull request that you are not the author of.

— https://help.github.com/en/github/authenticating-to-github/about-commit-signature-verification

This statement is no longer true 👆

Let's remove this part of the sentence:

except for when you squash and merge a pull request that you are not the author of.
@docs-bot docs-bot added the help wanted Anyone is welcome to open a pull request to fix this issue label Oct 11, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 11, 2021
@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team label Oct 18, 2021
@outsideris outsideris mentioned this issue Oct 27, 2021
Merged
5 tasks
@roosta roosta mentioned this issue Nov 17, 2022
Merged
@Sarrac3873 Sarrac3873 mentioned this issue Dec 19, 2023
Open
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this issue Dec 19, 2023
Open
@aliscco aliscco mentioned this issue Dec 20, 2023
Open
@avengerfart avengerfart mentioned this issue Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incorrect info related with GPG sign outsideris/docs
3 participants
@ramyaparimi @docs-bot and others