Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include step to add "webrick" gem on "Testing your GitHub Pages site locally with Jekyll" page #14492

Closed
1 task done
caseycarroll opened this issue Jan 23, 2022 · 3 comments · Fixed by #16137
Closed
1 task done
Assignees
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue MLH fellowship This issue is reserved for the MLH Fellowship program

Comments

@caseycarroll
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll

What part(s) of the article would you like to see updated?

Ruby 3.0 no longer bundles the webrick gem. The docs should include a step to add gem webrick to the reader's Gemfile.

After completing prerequisites for "Testing your GitHub Pages site locally with Jekyll", bundle exec jekyll serve fails because jekyll can't find the webrick gem.

I suggest the following changes under the "Building your site locally" section

1. Open Git Bash.
2. Navigate to the publishing source for your site. For more information about publishing sources, see "About GitHub Pages."
++ 3. Open the project's Gemfile
++ 4. Add the `webrick` gem anywhere in the file
++ ```gem "webrick"```
++ 5. Save and close Gemfile
6. Run your Jekyll site locally. 
7. To preview your site, in your web browser, navigate to http://localhost:4000.

For more info see jekyll/jekyll#8523

Additional information

No response

@caseycarroll caseycarroll added the content This issue or pull request belongs to the Docs Content team label Jan 23, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 23, 2022
@github-actions github-actions bot added this to Triage in Docs open source board Jan 23, 2022
@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team label Jan 24, 2022
@ramyaparimi ramyaparimi removed this from Triage in Docs open source board Jan 24, 2022
@stevecat
Copy link
Member

Hi @caseycarroll! Thanks for opening this ✨

It looks like webrick will become a dependancy of Jekyll in v4.3.0 onwards (see: jekyll/jekyll#8524 and jekyll/jekyll#8778 (comment)) which will resolve this.

I don't think we should include this as part of the procedural because it's only going to help folks with Ruby 3.0 and versions of Jekyll prior to webrick being added as a dependancy. I think adding a note callout could really help those folks stuck in this particular scenario though. We can come back and remove it later.

I've just closed #14511 as I think it will be easier to start over. I'd suggest adding a {% note %} callout below the procedural, mentioning that folks using Ruby 3.0 and Jekyll v4.2.x and older will need to add gem "webrick" to their project's Gemfile and run bundle install.

I'll include a link to our docs on callout tags below:

https://github.com/github/docs/blob/main/contributing/content-markup-reference.md#callout-tags

You (or anyone else!) can open a PR to work on this! 😸

@github-actions github-actions bot added this to Triage in Docs open source board Feb 17, 2022
@ramyaparimi ramyaparimi added the help wanted Anyone is welcome to open a pull request to fix this issue label Feb 17, 2022
@docubot docubot moved this from Triage to Help wanted in Docs open source board Feb 17, 2022
@caseycarroll
Copy link
Author

@stevecat thank you for looking into this! I totally agree with your suggestion. I'm glad to hear Jekyll will include webrick. If I have time, I'll implement that suggestion, but yes, anyone else should feel free to take this one!

@ramyaparimi ramyaparimi added this to Weeks 4-6 in MLH Fellowship Mar 1, 2022
@ramyaparimi ramyaparimi added the MLH fellowship This issue is reserved for the MLH Fellowship program label Mar 1, 2022
@riteshsp2000 riteshsp2000 self-assigned this Mar 8, 2022
vgrl added a commit to riteshsp2000/docs that referenced this issue Mar 17, 2022
ramyaparimi added a commit to riteshsp2000/docs that referenced this issue Mar 18, 2022
Docs open source board automation moved this from Help wanted to Done Mar 18, 2022
vgrl added a commit that referenced this issue Mar 18, 2022
fix: add a note to install the webrick gem for Ruby 3.0 users
@janiceilene janiceilene moved this from Weeks 4-6 to Weeks 10-12 in MLH Fellowship Apr 1, 2022
@janiceilene janiceilene moved this from Weeks 10-12 to Done in MLH Fellowship Apr 1, 2022
@mohsinaav
Copy link

Tyvm.

This is really helpful for someone like me who is a total beginner in jekyll and ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue MLH fellowship This issue is reserved for the MLH Fellowship program
Projects
6 participants
@caseycarroll @stevecat @mohsinaav @ramyaparimi @riteshsp2000 and others