Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the I understand my workflows screen #15761

Closed
1 task done
jsoref opened this issue Feb 23, 2022 · 4 comments
Closed
1 task done

Document the I understand my workflows screen #15761

jsoref opened this issue Feb 23, 2022 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert SME stale The request for an SME has staled waiting for review Issue/PR is waiting for a writer's review

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 23, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions
https://docs.github.com/en/actions/managing-workflow-runs

What part(s) of the article would you like to see updated?

Something should describe this page that users will see, explain what it means, and link to pages that actually talk about the security ramifications of enabling workflows.

It should also explain how to get to this screen. And it could be helpful if it explains "If your fork predates the introduction of workflows in the upstream, instead of seeing this screen, you may see the Get started with GitHub Actions screen, in order to get the existing upstream workflows, you'll need to use fetch upstream feature".

Expected outcome: I should be able to link to a page from my documentation in order to help a user of a fork understand how to enable workflows in order to explain how they can start using my workflow (which is present in the upstream).

Additional information

image

GitHub Actions
Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

View the workflows directory


Fwiw, while you're adding documentation, you could also mention:

While this message says when it was forked, you may see this message if you use the fetch upstream feature to pull workflows into a fork that was forked before workflows were added to the upstream.

-- Alternatively, the message itself could be changed to not provide a misleading statement...

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Feb 23, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 23, 2022
@github-actions github-actions bot added this to Triage in Docs open source board Feb 23, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 23, 2022
@ramyaparimi
Copy link
Contributor

@jsoref
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
@github-actions
Copy link
Contributor

This is a gentle bump for the docs team that this issue is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Apr 12, 2022
@ramyaparimi
Copy link
Contributor

@jsoref
Thanks so much for your patience. I spoke with the team and we are not going to accept this contribution 💛. We really appreciate your time and interest in improving GitHub docs 💖 .

Docs open source board automation moved this from Triage to Done Apr 13, 2022
EliahKagan added a commit to EliahKagan/EmbeddingScratchwork that referenced this issue Mar 15, 2023
My previous wording had effectively suggested that the inherited CI
workflows would be enabled automatically in a fork, which is not
the case. This commit addresses how to enable them in a a forked
repository's Actions tab.

I don't want to put an enormous amount of what is effectively
general GitHub documentation in the readme, since the readme is
already verging on being excessively long. But this is
unfortunately not well documented in the GitHub docs. (See
github/docs#15761, which was closed
as completed, but appears actually to have been declined.)

In the Actions tab of a newly created fork, this message is shown:

> Workflows aren’t being run on this forked repository
>
> Because this repository contained workflow files when it was
> forked, we have disabled them from running on this fork. Make
> sure you understand the configured workflows and their expected
> usage before enabling Actions on this repository.

There is a button "I understand my workflows, go ahead and enable
them" as well as a link "View the workflows directory".

I've largely not documented the details of this; I note them in
this commit message so it's clear what the changes in this commit
refer to in case the GitHub user interface changes in the future,
and for insight.

Instead, I've linked to two pages where they are discussed: the
GitHub docs bug report, and documentation for an unrelated project.
These sources are imperfect, since neither is intended as *general*
documentation, and maybe the information should be reproduced in
our readme, but for now I think this may be enough.
dmvassallo added a commit to dmvassallo/EmbeddingScratchwork that referenced this issue Mar 22, 2023
* Document how to enable workflows

My previous wording had effectively suggested that the inherited CI
workflows would be enabled automatically in a fork, which is not
the case. This commit addresses how to enable them in a a forked
repository's Actions tab.

I don't want to put an enormous amount of what is effectively
general GitHub documentation in the readme, since the readme is
already verging on being excessively long. But this is
unfortunately not well documented in the GitHub docs. (See
github/docs#15761, which was closed
as completed, but appears actually to have been declined.)

In the Actions tab of a newly created fork, this message is shown:

> Workflows aren’t being run on this forked repository
>
> Because this repository contained workflow files when it was
> forked, we have disabled them from running on this fork. Make
> sure you understand the configured workflows and their expected
> usage before enabling Actions on this repository.

There is a button "I understand my workflows, go ahead and enable
them" as well as a link "View the workflows directory".

I've largely not documented the details of this; I note them in
this commit message so it's clear what the changes in this commit
refer to in case the GitHub user interface changes in the future,
and for insight.

Instead, I've linked to two pages where they are discussed: the
GitHub docs bug report, and documentation for an unrelated project.
These sources are imperfect, since neither is intended as *general*
documentation, and maybe the information should be reproduced in
our readme, but for now I think this may be enough.

* Fix line length in README

---------

Co-authored-by: David Vassallo <vassallo.davidm@gmail.com>
@tchebb
Copy link

tchebb commented Apr 22, 2023

Since it looks like everyone who wants to refer to this screen just links to this issue in the absence of real documentation, I want to flag this bug I just reported, where certain pushes that touch files in .github/workflows/ will silently dismiss the screen and enable Actions. It confused me for a while today, so hopefully my investigation saves others time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert SME stale The request for an SME has staled waiting for review Issue/PR is waiting for a writer's review
Projects
No open projects
Development

No branches or pull requests

4 participants
@tchebb @jsoref @ramyaparimi and others