Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securing-your-github-pages-site-with-https page should mention cases with Cloudflare #2683

Closed
Andre601 opened this issue Jan 8, 2021 · 3 comments

Comments

@Andre601
Copy link
Contributor

Andre601 commented Jan 8, 2021

What article on docs.github.com is affected?

https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/securing-your-github-pages-site-with-https

What part(s) of the article would you like to see updated?

The page doesn't mention, that the issue with the HTTPS Enforcement not being available could also be caused by using Cloudflare to resolve your DNS settings, as the proxying of the DNS records/requests makes it unable for GitHub to actually check the DNS settings properly (See this answer for the actual info)

Additional information

Many people use Cloudflare and may also use GitHub Pages, so mentioning this as a common cause would go a long way in helping people.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 8, 2021
@github-actions github-actions bot added this to Triage in Docs open source board Jan 8, 2021
@janiceilene janiceilene removed the triage Do not begin working on this issue until triaged by the team label Jan 8, 2021
@janiceilene
Copy link
Contributor

Thanks for opening an issue @Andre601! I've triaged your pull request for review 🎉

@chiedo chiedo added the core label Jan 11, 2021
@chiedo chiedo moved this from Triage to Core in Docs open source board Jan 11, 2021
@janiceilene janiceilene moved this from Core to Anyone in Docs open source board Jan 11, 2021
@janiceilene janiceilene removed this from Content review needed in Docs open source board Feb 18, 2021
@janiceilene
Copy link
Contributor

Thanks so much for opening this issue! I've checked back in with the team again and we've decided that we're not going to make this change.

We appreciate your interest and passion in improving the GitHub docs ✨

@Andre601
Copy link
Contributor Author

That issue took quite some time to be closed considering the PR related to it was denied much, much earlier.... Guess it went under the radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants