-
Notifications
You must be signed in to change notification settings - Fork 58.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention Cloudflare in securing with https #2684
Conversation
Edit: The note is displayed, but formatting (In this case bold text) isn't rendered properly. |
@Andre601 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Still active 👍 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Boop |
Why was this closed now? Broken Stale-check? |
@Andre601 That's exactly what happened! It's been fixed and I'm currently reopening PRs. So sorry about that! |
👋 @Andre601 I've spoken with the team and since this procedural would be documenting Cloudflare DNS we can't accept this PR. We try to only document GitHub and GitHub's UI whenever possible. Thank you so much for your continued dedication to improving GitHub's docs! |
Why:
closes #2683
The
securing-your-github-pages-site-with-https
page doesn't mention, that Cloudflare's proxying would be a common cause for HTTPS enforcement to not be possible.Since Cloudflare is used a lot by many people and since those people may also use GitHub Pages for static pages would it be a beneficial change to add this info.
Please give feedback for the changes made as I'm sure that they can be improved more.
What's being changed:
securing-your-github-pages-site-with-https.md
received an extra section called### Cloudflare DNS
which explains the steps on how to configure your DNS on Cloudflare to allow the "Enforce HTTPS" setting in your repository's GitHub Pages setting.Check off the following: