Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Cloudflare in securing with https #2684

Closed
wants to merge 2 commits into from

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented Jan 8, 2021

Why:

closes #2683

The securing-your-github-pages-site-with-https page doesn't mention, that Cloudflare's proxying would be a common cause for HTTPS enforcement to not be possible.

Since Cloudflare is used a lot by many people and since those people may also use GitHub Pages for static pages would it be a beneficial change to add this info.

Please give feedback for the changes made as I'm sure that they can be improved more.

What's being changed:

securing-your-github-pages-site-with-https.md received an extra section called ### Cloudflare DNS which explains the steps on how to configure your DNS on Cloudflare to allow the "Enforce HTTPS" setting in your repository's GitHub Pages setting.

Check off the following:

@Andre601
Copy link
Contributor Author

Andre601 commented Jan 8, 2021

The note isn't displayed properly and I can't find a proper way to fix this, so if an expert has knowledge on how to fix it would I appreciate the help.

Edit: The note is displayed, but formatting (In this case bold text) isn't rendered properly.

@janiceilene
Copy link
Contributor

@Andre601 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 8, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 16, 2021
@Andre601
Copy link
Contributor Author

Still active 👍

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 17, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 27, 2021
@Andre601
Copy link
Contributor Author

Boop

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
Docs open source board automation moved this from Anyone to Done Feb 13, 2021
@Andre601
Copy link
Contributor Author

Why was this closed now? Broken Stale-check?

@janiceilene
Copy link
Contributor

@Andre601 That's exactly what happened! It's been fixed and I'm currently reopening PRs. So sorry about that!

@janiceilene janiceilene reopened this Feb 16, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@janiceilene janiceilene moved this from Done to Content review needed in Docs open source board Mar 16, 2021
@janiceilene
Copy link
Contributor

👋 @Andre601 I've spoken with the team and since this procedural would be documenting Cloudflare DNS we can't accept this PR. We try to only document GitHub and GitHub's UI whenever possible. Thank you so much for your continued dedication to improving GitHub's docs!

Docs open source board automation moved this from Content review needed to Done Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Development

Successfully merging this pull request may close these issues.

securing-your-github-pages-site-with-https page should mention cases with Cloudflare
3 participants