Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing step in "Associating an email with your gpg key" #2722

Closed
layaxx opened this issue Jan 9, 2021 · 3 comments · Fixed by #2723
Closed

missing step in "Associating an email with your gpg key" #2722

layaxx opened this issue Jan 9, 2021 · 3 comments · Fixed by #2723

Comments

@layaxx
Copy link
Contributor

layaxx commented Jan 9, 2021

What article on docs.github.com is affected?

Associating an email with your gpg key

What part(s) of the article would you like to see updated?

This misses an important step.
To actually save the changes to the pgp key, you have to type pgp> save into the console.
The current wording makes is sound like confirming the changes with o saves the changes, which is not the case.

Additional information

I think the article would benefit from a clarification, so it is easier to follow.

Edit: See #2723 for proposed changes

@welcome
Copy link

welcome bot commented Jan 9, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 9, 2021
@chiedo chiedo added core and removed triage Do not begin working on this issue until triaged by the team labels Jan 11, 2021
@chiedo
Copy link
Contributor

chiedo commented Jan 11, 2021

@layaxx thanks for opening an issue! I’ll triage this for the right team to take a look 👀

@janiceilene janiceilene linked a pull request Jan 11, 2021 that will close this issue
3 tasks
@felicitymay
Copy link
Contributor

👋🏻 Hi @layaxx - thanks for your patience.

Thank you for raising this issue to tell us (and other users) about the missing step ✨
It's really helpful when people let us know about omissions like this, especially when they take the time to explain the problem and the correction clearly as you have done here.

I see that you've also raised a PR to fix it. I'll go and review that now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@felicitymay @chiedo @layaxx and others