Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying that X-GitHub-Delivery is unique per event, not per delivery #33184

Merged
merged 4 commits into from
May 27, 2024

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented May 26, 2024

Why:

This PR clarifies information about how X-GitHub-Delivery is used.

Note

Check out the Additional Information section of this issue for more context.

Making this change helps users to learn how to correctly use this feature.
Closes #32822

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 26, 2024
Copy link
Contributor

github-actions bot commented May 26, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
webhooks/using-webhooks/best-practices-for-using-webhooks.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
webhooks/webhook-events-and-payloads.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team webhooks Content related to webhooks and removed triage Do not begin working on this issue until triaged by the team labels May 27, 2024
@nguyenalex836
Copy link
Contributor

@CBID2 Hello! 👋 Changes look great - just one issue I noticed, left a comment for you above 💛

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label May 27, 2024
@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label May 27, 2024
@nguyenalex836
Copy link
Contributor

@CBID2 Thanks so much for opening a PR with these fixes! With that typo resolved, I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue May 27, 2024
Merged via the queue into github:main with commit ad3f828 May 27, 2024
46 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@CBID2 CBID2 deleted the clarifying-information branch May 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team webhooks Content related to webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that X-GitHub-Delivery is unique per event, not per delivery
2 participants