Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github-apps): explain github apps name characters limit #33265

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

sheeeng
Copy link
Contributor

@sheeeng sheeeng commented May 31, 2024

Name for GitHub Apps cannot be longer than 34 characters.

Why: Explain names for GitHub Apps cannot be longer than 34 characters.

Closes: Not applicable.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Name for GitHub Apps cannot be longer than 34 characters.
Copy link

welcome bot commented May 31, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 31, 2024
Copy link
Contributor

github-actions bot commented May 31, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/registering-a-github-app/registering-a-github-app.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@sheeeng sheeeng changed the title docs/explain-github-apps-name-characters-limit docs: explain-github-apps-name-characters-limit May 31, 2024
@sheeeng sheeeng changed the title docs: explain-github-apps-name-characters-limit docs(github-apps): explain-github-apps-name-characters-limit May 31, 2024
@sheeeng sheeeng changed the title docs(github-apps): explain-github-apps-name-characters-limit docs(github-apps): explain github apps name characters limit May 31, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels May 31, 2024
@nguyenalex836
Copy link
Contributor

@sheeeng Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! We'll get this merged for you.

@skedwards88 skedwards88 added this pull request to the merge queue Jun 1, 2024
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jun 1, 2024
@docs-bot docs-bot added this to Triage in Docs open source board Jun 1, 2024
Merged via the queue into github:main with commit dd26a54 Jun 1, 2024
53 checks passed
Docs open source board automation moved this from Triage to Done Jun 1, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants