Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded periods from list #33655

Merged

Conversation

SeanAverS
Copy link
Contributor

@SeanAverS SeanAverS commented Jun 22, 2024

Why:

Remove periods from list because list items are not complete sentences

Closes: #33638

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Remove periods on all list items under line 41

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 22, 2024
Copy link
Contributor

github-actions bot commented Jun 22, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-github-profile/customizing-your-profile/setting-your-profile-to-private.md fpt
fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

nguyenalex836
nguyenalex836 previously approved these changes Jun 24, 2024
nguyenalex836
nguyenalex836 previously approved these changes Jun 24, 2024
@nguyenalex836
Copy link
Contributor

@SeanAverS Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

If you're looking for another issue to pick up, take a look at our help wanted section to find more open issues you can work on ✨

Fixing linter error - dashes to asterisks
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jun 24, 2024
Merged via the queue into github:main with commit ac91973 Jun 24, 2024
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove periods from list in setting-your-profile-to-private#changes-to-reporting-on-your-activities
2 participants