Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtering-and-searching-issues-and-pull-requests.md #33908

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

ko23
Copy link
Contributor

@ko23 ko23 commented Jul 9, 2024

Adding additional information about querying Pull Requests with is:merged and is:unmerged filters

Why:

Closes: #33906

What's being changed (if available, include any code snippets, screenshots, or gifs):

small but valuable update - only one line added
Filter issues by state of merging: is:merged or is:unmerged

it's a small but valuable update: adding is:merged and is:unmerged filters for Pull Requests queries
It can help with combining with other filters such as is:closed

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Adding additional information about querying Pull Requests with `is:merged` and `is:unmerged` filters
Copy link

welcome bot commented Jul 9, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
issues/tracking-your-work-with-issues/filtering-and-searching-issues-and-pull-requests.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

ko23 added 2 commits July 9, 2024 22:56
smallfix - changing link - removing obsolete `.md`
(docfix): removing trailing spaces for empty line
@nguyenalex836
Copy link
Contributor

@ko23 Thanks so much for opening a PR! ✨ I noticed you added the new line under

For issues, you can also use search to:

Do you think it might make more sense to add the new line under the following section, since the new line adds content relevant to PRs?

For pull requests, you can also use search to:

It would also make sense to update the line to read "Filter pull requests by state of merging..." (as it currently reads "Filter issues by state of merging..."

Let me know what you think! 💛

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Jul 9, 2024
@ko23
Copy link
Contributor Author

ko23 commented Jul 9, 2024

@nguyenalex836

  • thank you for super-fast and valuable review
  • "Do you think it might make more sense to add the new line under the following section, since the new line adds content relevant to PRs?" -> yes it can be good idea
  • "It would also make sense to update the line to read "Filter pull requests by state of merging..." (as it currently reads "Filter issues by state of merging..." " -> ok, your proposal is better

Do you want to make changes by myself to this particular Pull Request or it should be done in other way?

@nguyenalex836
Copy link
Contributor

@ko23 No problem at all! 💛 Feel free to make the changes yourself, and let me know whenever you are ready for me to review again!

- moving from filtering issues to filtering Pull request
- adding link to "About pull request merges" (`pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges`)
@ko23
Copy link
Contributor Author

ko23 commented Jul 10, 2024

@nguyenalex836

  • I've just moved line to the Pull Request Section, as suggested (and I changed Filter issues to Filter Pull Requests
  • I've also added link to About pull request merges for better navigation

@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label Jul 10, 2024
@nguyenalex836
Copy link
Contributor

@ko23 These changes look wonderful! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into github:main with commit a5e9ddb Jul 10, 2024
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of information about is:merged and is:unmerged filters for Pull Requests queries
2 participants