-
Notifications
You must be signed in to change notification settings - Fork 58.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filtering-and-searching-issues-and-pull-requests.md #33908
Conversation
Adding additional information about querying Pull Requests with `is:merged` and `is:unmerged` filters
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
smallfix - changing link - removing obsolete `.md`
(docfix): removing trailing spaces for empty line
@ko23 Thanks so much for opening a PR! ✨ I noticed you added the new line under
Do you think it might make more sense to add the new line under the following section, since the new line adds content relevant to PRs?
It would also make sense to update the line to read "Filter pull requests by state of merging..." (as it currently reads "Filter issues by state of merging..." Let me know what you think! 💛 |
Do you want to make changes by myself to this particular Pull Request or it should be done in other way? |
@ko23 No problem at all! 💛 Feel free to make the changes yourself, and let me know whenever you are ready for me to review again! |
- moving from filtering issues to filtering Pull request - adding link to "About pull request merges" (`pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges`)
|
@ko23 These changes look wonderful! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Adding additional information about querying Pull Requests with
is:merged
andis:unmerged
filtersWhy:
Closes: #33906
What's being changed (if available, include any code snippets, screenshots, or gifs):
small but valuable update - only one line added
Filter issues by state of merging:
is:merged
oris:unmerged
it's a small but valuable update: adding is:merged and is:unmerged filters for Pull Requests queries
It can help with combining with other filters such as is:closed
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.