Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Ruff linter call example #33951

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Corrected Ruff linter call example #33951

merged 2 commits into from
Jul 15, 2024

Conversation

howroyd
Copy link
Contributor

@howroyd howroyd commented Jul 12, 2024

ruff <path> has been removed. Use ruff check <path> instead.

astral-sh/ruff-vscode#132

Why:

Closes: #33950

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

`ruff <path>` has been removed. Use `ruff check <path>` instead.

astral-sh/ruff-vscode#132
Copy link

welcome bot commented Jul 12, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 12, 2024
Copy link
Contributor

github-actions bot commented Jul 12, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/automating-builds-and-tests/building-and-testing-python.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@howroyd
Copy link
Contributor Author

howroyd commented Jul 12, 2024

Staging looks good, I only added one word.

I assuming all the placeholders are not my responsibility to review? e.g.

{% data reusables.actions.enterprise-github-hosted-runners %}

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 12, 2024
@nguyenalex836
Copy link
Contributor

@howroyd Thanks so much for opening a PR! I'll get this triaged for review ✨ The team will have more feedback regarding the reusable upon review 💛

@sunbrye sunbrye self-requested a review July 15, 2024 18:49
@sunbrye
Copy link
Contributor

sunbrye commented Jul 15, 2024

Hi @howroyd 👋 Thank you so much for pointing out this error and updating the example!

I assuming all the placeholders are not my responsibility to review? e.g.

I've reviewed the resuables and they look good as they have not been touched.

Thank you again for your contribution and I'll get this merged ✨

@sunbrye sunbrye added this pull request to the merge queue Jul 15, 2024
Merged via the queue into github:main with commit 576529f Jul 15, 2024
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@howroyd howroyd deleted the patch-1 branch August 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruff call syntax has changed for Python linting
3 participants