Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix creating-a-composite-action.md #34197

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Bugfix creating-a-composite-action.md #34197

merged 4 commits into from
Aug 7, 2024

Conversation

misafu
Copy link
Contributor

@misafu misafu commented Aug 5, 2024

Existing template incorrectly uses 'actions' where should be present.

Why:

Closes:

#34196

What's being changed (if available, include any code snippets, screenshots, or gifs):

The template is and instructions are changed to specify the user's username should be used, not the word 'actions'

Check off the following:

  • [ X] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [ X] For content changes, I have completed the self-review checklist.

Existing template incorrectly uses 'actions' where <username> should be present.
Copy link

welcome bot commented Aug 5, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/creating-actions/creating-a-composite-action.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 5, 2024
@nguyenalex836
Copy link
Contributor

@misafu Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @misafu — I agree this is slightly misleading. I've made suggestions based on our placeholder guidance, and the fact that repository owner would be more appropriate (and applicable in every circumstance).

@nguyenalex836 nguyenalex836 added more-information-needed More information is needed to complete review and removed waiting for review Issue/PR is waiting for a writer's review labels Aug 6, 2024
misafu and others added 3 commits August 7, 2024 11:38
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
@misafu misafu requested a review from subatoi August 7, 2024 05:17
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll go ahead and get this merged.

Thanks for your interest in the GitHub Docs!

@subatoi subatoi added this pull request to the merge queue Aug 7, 2024
Merged via the queue into github:main with commit ed87739 Aug 7, 2024
45 checks passed
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants