-
Notifications
You must be signed in to change notification settings - Fork 58.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pwsh
commands
#34253
base: main
Are you sure you want to change the base?
Update pwsh
commands
#34253
Conversation
Update all instances of `"something" | Out-File -FilePath $env:GITHUB_ENV -Append` as this does not work with the shell set to `pwsh` consistently. Consistent results were only visible using the ` >> ` mode.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Per @jessehouwing request I also updated the random generator to be `(New-Guid).Guid` instead of something more complicated.
pwsh
commands
@MrHinsh Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Why:
Currently, in the documentation for workflow-commands-for-github-actions it states that a valid use of PowerShell is:
"$Something" | Out-File -FilePath $env:GITHUB_ENV -Append
However, this does not work for the hosted
Ubuntu-Latest
agents running with thepwsh
shell.What's being changed:
I have updated all of the powershell commands on this page to be the working format of:
"$Something" >> $env:GITHUB_ENV
Which I have tested produces consistent results.
I have left all older PowerShell commands and only updated the Powershell Core ones.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.