Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push example: build with the release configuration #4406

Merged
merged 4 commits into from
Mar 25, 2021
Merged

push example: build with the release configuration #4406

merged 4 commits into from
Mar 25, 2021

Conversation

freddyrios
Copy link
Contributor

@freddyrios freddyrios commented Mar 9, 2021

the push line expects a release build

Why:

Fixes broken example where publish fails to find the built files

What's being changed:

The dotnet build line was missing the "--configuration Release". Without that, this pattern fails to find any file "/bin/Release/.nupkg".
- run: dotnet build --configuration Release
- name: Create the package
run: dotnet pack --configuration Release
- name: Publish the package to GPR
run: dotnet nuget push /bin/Release/
.nupkg

Check off the following:

the push line expects a release build
@welcome
Copy link

welcome bot commented Mar 9, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

freddyrios added a commit to copenhagenatomics/CA_DataUploader that referenced this pull request Mar 9, 2021
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 16, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Mar 16, 2021
@janiceilene
Copy link
Contributor

@freddyrios Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Mar 16, 2021
@janiceilene janiceilene added this to Content review needed in Docs open source board Mar 16, 2021
@martin389 martin389 merged commit d1cc385 into github:main Mar 25, 2021
Docs open source board automation moved this from Content review needed to Done Mar 25, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@freddyrios freddyrios deleted the patch-1 branch March 25, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants