-
Notifications
You must be signed in to change notification settings - Fork 58.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
push example: build with the release configuration #4406
Conversation
the push line expects a release build
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
@freddyrios Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
the push line expects a release build
Why:
Fixes broken example where publish fails to find the built files
What's being changed:
The dotnet build line was missing the "--configuration Release". Without that, this pattern fails to find any file "/bin/Release/.nupkg".
- run: dotnet build --configuration Release
- name: Create the package
run: dotnet pack --configuration Release
- name: Publish the package to GPR
run: dotnet nuget push /bin/Release/.nupkg
Check off the following: