Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navigation-has-label docs #100

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Aug 29, 2023

Making clear that aria-labelledby to a heading is preferred where possible.

@khiga8 khiga8 requested a review from a team as a code owner August 29, 2023 14:48
Copy link
Contributor

@lindseywild lindseywild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve with the 2 suggestions!

docs/rules/accessibility/navigation-has-label.md Outdated Show resolved Hide resolved
docs/rules/accessibility/navigation-has-label.md Outdated Show resolved Hide resolved
khiga8 and others added 2 commits August 29, 2023 11:58
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>
@khiga8 khiga8 merged commit c395692 into main Aug 29, 2023
10 checks passed
@khiga8 khiga8 deleted the kh-update-accessible-name-docs branch August 29, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants