Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't flag title on link tag #110

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Don't flag title on link tag #110

merged 3 commits into from
Sep 28, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Sep 28, 2023 •
edited
Loading

Fixes: #108

It seems reasonable to not flag the <link> tag given it's NOT user-facing and title has special semantics on the link element to define a default or an alternate stylesheet.

@khiga8 khiga8 requested a review from a team as a code owner September 28, 2023 14:15
@khiga8 khiga8 mentioned this pull request Sep 28, 2023
Closed
smockle
smockle approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, great callout! LGTM!

@khiga8 khiga8 merged commit b4ba76b into main Sep 28, 2023
11 checks passed
@khiga8 khiga8 deleted the kh-except-link-tag branch September 28, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smockle smockle smockle approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GitHub::Accessibility::NoTitleAttribute] False positive on <link> tag
2 participants
@khiga8 @smockle