Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aria label is well formatted docs to be more helpful #65

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Update Aria label is well formatted docs to be more helpful #65

merged 4 commits into from
Apr 14, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Apr 14, 2023 •
edited
Loading

I am updating the docs to hopefully be more informative after reviewing the flagged offenses in our app (staff-only link)

@khiga8 khiga8 marked this pull request as ready for review April 14, 2023 00:20
@khiga8 khiga8 requested a review from a team as a code owner April 14, 2023 00:20
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

khiga8 and others added 3 commits April 14, 2023 08:27
@khiga8 @JoyceZhu
Update docs/rules/accessibility/aria-label-is-well-formatted.md
2c893f8 
Co-authored-by: Joyce Zhu <joycezhu@github.com>
@khiga8 @JoyceZhu
Update docs/rules/accessibility/aria-label-is-well-formatted.md
9ba998f 
Co-authored-by: Joyce Zhu <joycezhu@github.com>
@khiga8 @JoyceZhu
Update docs/rules/accessibility/aria-label-is-well-formatted.md
d37f91c 
Co-authored-by: Joyce Zhu <joycezhu@github.com>
@khiga8 khiga8 requested a review from JoyceZhu April 14, 2023 12:28
@khiga8 khiga8 merged commit 65378df into main Apr 14, 2023
@khiga8 khiga8 deleted the kh-update-docs branch April 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyceZhu JoyceZhu JoyceZhu approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khiga8 @accessibility-bot @JoyceZhu