Merge pull request #94 from github/remove-node-config-and-babel

Remove node config and babel
github · Mar 18, 2020 · 7bbc2a1 · 7bbc2a1
2 parents e278c1f + 396744b
commit 7bbc2a1
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 132 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,7 +1,6 @@
 module.exports = {
-  parser: 'babel-eslint',
   parserOptions: {
-    ecmaVersion: 6
+    ecmaVersion: 2020
   },
   env: {
     es6: true,

diff --git a/bin/eslint-github-init.js b/bin/eslint-github-init.js
@@ -35,7 +35,7 @@ const questions = [
     type: 'list',
     name: 'env',
     message: 'Which environment does this library target?',
-    choices: ['browser', 'node'],
+    choices: ['browser'],
     default: defaults.env
   },
   {
@@ -50,9 +50,7 @@ const questions = [
 inquirer.prompt(questions).then(answers => {
   const eslintrc = {extends: ['plugin:github/es6']}
 
-  if (answers.env === 'node') {
-    eslintrc.extends.push('plugin:github/node')
-  } else if (answers.project === 'app') {
+  if (answers.project === 'app') {
     eslintrc.extends.push('plugin:github/app')
   } else if (answers.env === 'browser') {
     eslintrc.extends.push('plugin:github/browser')

diff --git a/docs/configs.md b/docs/configs.md
@@ -29,7 +29,3 @@ Recommended rules when using Babel to transpile features from ES2015+.
 ### `plugin:github/app`
 
 Recommended rules when writing a browser application.
-
-### `plugin:github/node`
-
-Recommended rules when writing a node application.
diff --git a/lib/configs/node.js b/lib/configs/node.js
diff --git a/lib/index.js b/lib/index.js
@@ -21,7 +21,6 @@ module.exports = {
     app: require('./configs/app'),
     browser: require('./configs/browser'),
     es6: require('./configs/es6'),
-    node: require('./configs/node'),
     recommended: require('./configs/recommended'),
     typescript: require('./configs/typescript')
   }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,13 +28,9 @@
     "url": "https://github.com/github/eslint-plugin-github/issues"
   },
   "homepage": "https://github.com/github/eslint-plugin-github#readme",
-  "engines": {
-    "node": ">=8.11.1"
-  },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": ">=2.5.0",
     "@typescript-eslint/parser": ">=2.5.0",
-    "babel-eslint": ">=10.0.3",
     "eslint-config-prettier": ">=6.4.0",
     "eslint-plugin-eslint-comments": ">=3.0.1",
     "eslint-plugin-import": ">=2.18.2",
@@ -44,7 +40,8 @@
     "prettier": ">=1.12.0",
     "read-pkg-up": ">=6.0.0",
     "supports-color": "^7.1.0",
-    "svg-element-attributes": ">=1.2.1"
+    "svg-element-attributes": ">=1.2.1",
+    "to-fast-properties": "^3.0.1"
   },
   "peerDependencies": {
     "eslint": ">=4.19.0"