Merge branch 'main' into set-correct-meta-info-on-rules

github · Apr 1, 2021 · bc687f5 · bc687f5
2 parents 5e2959d + 25c29a0
commit bc687f5
Show file tree

Hide file tree

Showing 10 changed files with 3,970 additions and 1,104 deletions.
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
@@ -1,5 +1,7 @@
 # eslint-plugin-github
 
+[![Node CI](https://github.com/github/eslint-plugin-github/actions/workflows/nodejs.yml/badge.svg)](https://github.com/github/eslint-plugin-github/actions/workflows/nodejs.yml)
+
 ## Installation
 
 ```sh

diff --git a/lib/formatters/stylish-fixes.js b/lib/formatters/stylish-fixes.js
@@ -12,7 +12,7 @@ try {
 }
 const getRuleURI = require('eslint-rule-documentation')
 
-module.exports = function(results) {
+module.exports = function (results) {
   let output = '\n'
   let errors = 0
   let warnings = 0
@@ -82,8 +82,5 @@ function diff(a, b) {
   fs.writeFileSync(aPath, a, {encoding: 'utf8'})
   fs.writeFileSync(bPath, b, {encoding: 'utf8'})
   const result = childProcess.spawnSync('diff', ['-U5', aPath, bPath], {encoding: 'utf8'})
-  return result.stdout
-    .split('\n')
-    .slice(2)
-    .join('\n')
+  return result.stdout.split('\n').slice(2).join('\n')
 }
diff --git a/lib/rules/get-attribute.js b/lib/rules/get-attribute.js
@@ -17,37 +17,36 @@ function isValidAttribute(name) {
   return validSVGAttributeSet.has(name) || (validAttributeName.test(name) && !invalidSVGAttributeSet.has(name))
 }
 
-module.exports = function(context) {
-  return {
-    meta: {
-      type: 'problem',
-      docs: {
-        description: 'disallow wrong usage of attribute names',
-        url: require('../url')(module)
-      },
-      fixable: 'code',
-      schema: []
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow wrong usage of attribute names',
+      url: require('../url')(module)
     },
-    CallExpression(node) {
-      if (!node.callee.property) return
-
-      const calleeName = node.callee.property.name
-      if (!attributeCalls.test(calleeName)) return
-
-      const attributeNameNode = node.arguments[0]
-      if (!attributeNameNode) return
-
-      if (!isValidAttribute(attributeNameNode.value)) {
-        context.report({
-          meta: {
-            fixable: 'code'
-          },
-          node: attributeNameNode,
-          message: 'Attributes should be lowercase and hyphen separated, or part of the SVG whitelist.',
-          fix(fixer) {
-            return fixer.replaceText(attributeNameNode, `'${attributeNameNode.value.toLowerCase()}'`)
-          }
-        })
+    fixable: 'code',
+    schema: []
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (!node.callee.property) return
+
+        const calleeName = node.callee.property.name
+        if (!attributeCalls.test(calleeName)) return
+
+        const attributeNameNode = node.arguments[0]
+        if (!attributeNameNode) return
+
+        if (!isValidAttribute(attributeNameNode.value)) {
+          context.report({
+            node: attributeNameNode,
+            message: 'Attributes should be lowercase and hyphen separated, or part of the SVG whitelist.',
+            fix(fixer) {
+              return fixer.replaceText(attributeNameNode, `'${attributeNameNode.value.toLowerCase()}'`)
+            }
+          })
+        }
       }
     }
   }

diff --git a/lib/rules/no-blur.js b/lib/rules/no-blur.js
@@ -1,4 +1,4 @@
-module.exports = function(context) {
+module.exports = function (context) {
   return {
     meta: {
       type: 'problem',

diff --git a/lib/rules/no-useless-passive.js b/lib/rules/no-useless-passive.js
@@ -15,7 +15,7 @@ module.exports = {
 
   create(context) {
     return {
-      ['CallExpression[callee.property.name="addEventListener"]']: function(node) {
+      ['CallExpression[callee.property.name="addEventListener"]']: function (node) {
         const [name, listener, options] = node.arguments
         if (name.type !== 'Literal') return
         if (passiveEventListenerNames.has(name.value)) return

diff --git a/lib/rules/prefer-observers.js b/lib/rules/prefer-observers.js
@@ -14,7 +14,7 @@ module.exports = {
 
   create(context) {
     return {
-      ['CallExpression[callee.property.name="addEventListener"]']: function(node) {
+      ['CallExpression[callee.property.name="addEventListener"]']: function (node) {
         const [name] = node.arguments
         if (name.type !== 'Literal') return
         if (!(name.value in observerMap)) return

diff --git a/lib/rules/require-passive-events.js b/lib/rules/require-passive-events.js
@@ -14,7 +14,7 @@ module.exports = {
 
   create(context) {
     return {
-      ['CallExpression[callee.property.name="addEventListener"]']: function(node) {
+      ['CallExpression[callee.property.name="addEventListener"]']: function (node) {
         const [name, listener, options] = node.arguments
         if (!listener) return
         if (name.type !== 'Literal') return