-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove time of day and tz info properly #83
Conversation
Signed-off-by: Zack Koppert <zkoppert@github.com>
@jmeridth Can add a test here if you are up for it and merge them together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If we need to deploy now I'm good. Can add test later tonight when back at keyboard.
- [x] change from splitting string to using datetime.datetime.fromisoformat since the format from GitHub API for a repositories created_at date is ISO 8601 (example: 2024-04-03T05:00:00Z) - [x] write tests to handle if the repo.created_at is a string or a datetime According to the github3.py library, the repository's [created_at date is a datetime.datetime obj](https://github.com/sigmavirus24/github3.py/blob/3bb730f11a70ab84f9f64835442dc4c9c62638ea/src/github3/repos/repo.py#L2938-L2941). This makes me wonder how we're getting a string. Signed-off-by: jmeridth <jmeridth@gmail.com>
@zkoppert I pushed up tests. I need to debug some more. The |
Have confirmed locally, the Looking at a couple more things and then will open this up for review and merge. |
repo.created_at is of type github3.repos.repo.ShortRepository which seems to have a created_at attribute of type string github3.repos.repo.Repository has a parsed created_at type of datetime.datetime object but that is not what we get back in collections Signed-off-by: jmeridth <jmeridth@gmail.com>
|
Signed-off-by: jmeridth <jmeridth@gmail.com>
Pull Request
Proposed Changes
fixes #82
Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
bug
,documentation
,enhancement
,infrastructure
, orbreaking