Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automated releases and auto labelling #99

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 23, 2024

Part of github/github-ospo#78

Pull Request

Proposed Changes

  • lint pr title adhering to conventional commits (helps with auto labelling)
    • Update CONTRIBUTING.md
      • automated releases
      • how to file a bug report
      • how to file an enhancement
    • Update pull_request_template with new standard
  • setup autolabelling through release-drafter github action config
  • create auto-labeler workflow
  • change release-drafter workflow to release
    • create release, including new tag
    • create discussion announcement based on release
    • build container images, tag them and release them

Manual Actions:

  • create revert and maintenance labels
  • put repository and category IDs into secrets for the discussion create action

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth self-assigned this Apr 23, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 23, 2024 03:04
@jmeridth jmeridth added the enhancement New feature or request label Apr 23, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these releases may silently fail on major version changes since we aren't updating action.yaml files. That sound right to you? We can make that a future pr (set of prs) if desired.

.github/pull_request_template.md Show resolved Hide resolved
@jmeridth
Copy link
Member Author

jmeridth commented Apr 23, 2024

I think these releases may silently fail on major version changes since we aren't updating action.yaml files. That sound right to you? We can make that a future pr (set of prs) if desired.

yes, currently, we, as the PR reviewers, need to confirm the action.yml was updated if we're going to flag a PR with the breaking label. We can automate that though. Definitely a new PR. I'm a fan of https://github.com/tj-actions/changed-files for checking if a file is in the change set.

Do you think this work is a major version bump? I haven't been doing that. 😬

Part of github/github-ospo#78

- [x] lint pr title adhering to conventional commits (helps with auto labelling)
  - [x] Update CONTRIBUTING.md
    - [x] automated releases
    - [x] how to file a bug report
    - [x] how to file an enhancement
  - [x] Update pull_request_template with new standard
- [x] setup autolabelling through release-drafter github action config
- [x] create auto-labeler workflow
- [x] change release-drafter workflow to release
  - [x] create release, including new tag
  - [x] create discussion announcement based on release
  - [x] build container images, tag them and release them

Manual Actions:

- [x] create `revert` and `maintenance` labels
- [x] put repository and category IDs into secrets for the discussion create action

Signed-off-by: jmeridth <jmeridth@gmail.com>
@zkoppert
Copy link
Member

No major bump needed for this one, just looking to the future.

@jmeridth jmeridth merged commit 890f40c into main Apr 23, 2024
22 checks passed
@jmeridth jmeridth deleted the jm-automated-releases-and-autolabelling branch April 23, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants