Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement default values and validation for status codes #376

Closed
wheresrhys opened this issue Aug 10, 2016 · 1 comment
Closed

Implement default values and validation for status codes #376

wheresrhys opened this issue Aug 10, 2016 · 1 comment

Comments

@wheresrhys
Copy link
Contributor

To comply with https://fetch.spec.whatwg.org/#dom-response, and equivalent to these 2 PRs on node-fetch
node-fetch/node-fetch#135
node-fetch/node-fetch#132

I'm happy to submit a PR if it's approved in principle

@mislav
Copy link
Contributor

mislav commented Aug 11, 2016

I'm fine of setting default HTTP status to 200 and text to "OK". This will be easy to implement. However, I don't think it's worth our time to implement the validation that the status code must be between 200–599. Our library should stay simple and doesn't need to conform to 100% of the spec— we aim to implement just the parts that will actually be useful to people in development.

@mislav mislav closed this as completed in 5fd8402 Nov 12, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants