Assign to self #52
Merged
Assign to self #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2014
|
If that works for you that works for me :-). Ready when you are… |
| @@ -17,6 +17,7 @@ | |||
| "eqnull": true, | |||
| "browser": true, | |||
| "globals": { | |||
| "Promise": false | |||
| "Promise": false, | |||
| "self": false | |||
There was a problem hiding this comment.
It might make more sense to switch the worker option on rather than defining self as a global.
(Similarly but potentially less importantly you could choose to switch on esnext instead of defining Promise as a global — but that defines a larger amount of stuff that you might not want defined)
There was a problem hiding this comment.
Oh nice, I didn't realize there was a worker option.
I'll give exnext a try too. Last time I think I was on an older jshint that didn't define Promise yet.
|
👍 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isomorphic-fetchwill need to be changed to stubglobal.selfinstead ofglobal.window.https://github.com/matthew-andrews/isomorphic-fetch/blob/master/server.js
Changes #48.
Obsoletes #49, #50.
cc @dgraham @matthew-andrews @knowledgecode