Api to ignore hosts #110
Closed
Api to ignore hosts #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Thank you for looking into this!
I'm afraid the solution offered here suggests hard coding configuration files with hostnames -- I'd like to avoid that; state should be either be communicated through the raft setup (when using raft) or written to the MySQL backend (when using MySQL). Reasons:
- Only the
activefreno node receives this API call; what happens to all the other nodes? - Our next
puppetrun would overwrite any changes to the config file
I'm curious if you are using freno and need to solve the problem? If so, I advise using http-checks.
|
Closing this as it is implemented in #149 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 news API routes:
/skip-host/<hostname>Adds host to MySQL ignore host list/recover-host/<hostname>Remove host from MySQL ignore host list/skipped-hostsList all hosts in MySQL ignore host listWorking on tests...
Closes: #28