Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the arguments to the extractor to be customized. #77

Closed

Conversation

wearhere
Copy link
Contributor

No description provided.

@mislav
Copy link
Contributor

mislav commented Jul 17, 2015

This is planned as a part of #72 but this is a good start. I will hold off merging until I think about how other extractors are going to look like.

@wearhere
Copy link
Contributor Author

Cool, sounds good to me.

@mislav mislav closed this in d3b9f41 Sep 29, 2016
@wearhere wearhere deleted the jeff/customize_extraction_task branch September 29, 2016 21:48
@wearhere
Copy link
Contributor Author

How does d3b9f41 close this? It looks like the arguments are still not customizable (here)

@mislav
Copy link
Contributor

mislav commented Sep 30, 2016

Oh sorry, maybe I closed it too early. The new command gemoji extract <path> is sort of customizable because it takes the path parameter and will take the size parameter in the future. So, you'll be able to use the CLI command for your customizable needs.

I don't see the need for images/unicode rake task to be customizable because that one just needs to extract the images into the dev environment for integration testing, i.e. testing that images are all present and accounted for, all 64 pixels in dimensions, no duplicates, etc. Why would we want to customize the rake task used in development?

@wearhere
Copy link
Contributor Author

I don't see the need for images/unicode rake task to be customizable

Oh yeah I just linked to the wrong task :) Cool to hear that gemoji extract will be customizable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants