Use host's network stack, not container's. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without using the host's network stack, the container may behave unexpectedly, such as failing to resolve internal addresses that the host _can_ resolve.
Use hosts's network stack by passing `--network=host` to `docker run`
|
Still testing. Will keep PR updated with status. |
j-dunham
approved these changes
May 4, 2023
|
I tested with Windows and MacOS and it worked as expected 🎉 |
|
🚨 Hi @mario-campos please do not merge. It needs to be coordinated with the merging of the labs PR so we do not break them. 🚨 |
Chaseshak
approved these changes
May 4, 2023
|
This is an awesome PR. Thank you so much. If you don't mind me asking, will this functionality be released to Github's Self-hosted runner? If so, what version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Docker container uses a "bridged" network stack, which can have strange and unexpected behaviors when those network settings differ from the host's network settings.
For example, supplying an address to an private/internally-resolvable host will cause gh actions-importer to fail to resolve because it does not have those DNS settings.
What's changing?
This PR changes the way that the Docker container is executed by passing the
--network=hostflag, which will run this container using the host's network stack. In theory, this shouldn't break anything.How's this tested?
Has not been tested yet.