Fix: command option types

[simonsanchez]

What's changing?

Fixes that came out of manual testing by the team.

To be merged after https://github.com/github/valet/pull/6208. Those changes fix a bug we found when running

audit bamboo -o tmp/ --confi-file-path some.yml

How's this tested?

Manually

For the commands that take in --source-file-path I took a copy of the YAML of the IN-COM build and saved it locally. For the migrate commands I created a private repo and tested against that.

The following commands have all succeeded. I'll update this block as a I go.

# for convenience
export PROJ=src/ActionsImporter/ActionsImporter.csproj


# Audit

dotnet run --project $PROJ -- audit bamboo -o tmp/

dotnet run --project $PROJ -- audit bamboo -o tmp/ --project IN

dotnet run --project $PROJ -- audit bamboo -o tmp/ -p IN


# Dry Run

dotnet run --project $PROJ -- dry-run bamboo deployment -o tmp/ --deployment-project-id 6553605

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ --plan-slug IN-COM

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ -p IN-COM

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ --plan-slug foo --source-file-path sample.yml

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ -p foo --source-file-path sample.yml

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ -p IN-COM --config-file-path config.yml

dotnet run --project $PROJ -- dry-run bamboo build -o tmp/ --plan-slug IN-COM --config-file-path config.yml


# Migrate

dotnet run --project $PROJ -- migrate bamboo deployment -o tmp/ --deployment-project-id 6553605 --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ --plan-slug IN-COM --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ -p IN-COM --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ --plan-slug foo --source-file-path sample.yml --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ -p foo --source-file-path sample.yml --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ --plan-slug IN-COM --config-file-path config.yml --target-url https://github.com/simonsanchez/valet-testing-integration

dotnet run --project $PROJ -- migrate bamboo build -o tmp/ -p IN-COM --config-file-path config.yml --target-url https://github.com/simonsanchez/valet-testing-integration

Closes: https://github.com/github/valet/issues/6210

[github-actions]

Unit Test Results

41 tests  ±0   41 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 8400785. ± Comparison against base commit 12938b7.

♻️ This comment has been updated with latest results.

[Chaseshak]

All the test commands run correctly for me!