Add option to disable the use of host network #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-dunham
changed the title
Chaseshak
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Command works for me and shows up in the help menu!
➜ gh-actions-importer git:(no-host-network) dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- dry-run bamboo build -p PAN-NOD -o tmp/bamboo
[2023-07-18 16:10:36] Logs: 'tmp/bamboo/log/valet-20230718-161036.log'
[2023-07-18 16:10:38] Output file(s):
[2023-07-18 16:10:38] tmp/bamboo/build/panda/nodeplan/.github/workflows/nodeplan.yml
➜ gh-actions-importer git:(no-host-network) ✗ dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- dry-run bamboo build -p PAN-NOD -o tmp/bamboo --no-host-network
[2023-07-18 16:10:50] Logs: 'tmp/bamboo/log/valet-20230718-161050.log'
[2023-07-18 16:10:51] Output file(s):
[2023-07-18 16:10:51] tmp/bamboo/build/panda/nodeplan/.github/workflows/nodeplan.yml
➜ gh-actions-importer git:(no-host-network) ✗ dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- dry-run bamboo build --help
ethanis
approved these changes
Jul 18, 2023
Co-authored-by: Ethan Dennis <ethanis@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing?
Adds a new CLI flag
--no-host-networkto prevent the use of the host network while running the docker commands. If the flag is not present then the docker run command is generate as it was before with the--network=host. When the new flag is present the--network=hostwill not be added.Relates to #172
How's this tested?
specs and 👀
Closes github/valet/issues/6619