Add support for custom Docker registries #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaseshak
commented
Oct 3, 2023
Chaseshak
requested review from
simonsanchez,
luke-engle,
ethanis and
ArinGhazarian
ethanis
reviewed
Oct 3, 2023
Chaseshak
force-pushed
the
support-custom-registries
branch
2 times, most recently
from
cd6e788
to
514a748
Compare
This allows a user to set the `CONTAINER_REGISTRY` environment variable which can be used in place of the default of ghcr.io if a customer would like to mirror our image so they can self host behind any proxies or other custom network stack.
Chaseshak
force-pushed
the
support-custom-registries
branch
from
514a748
to
70de5da
Compare
j-dunham
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing?
This allows a user to set the
CONTAINER_REGISTRYenvironment variablewhich can be used in place of the default of ghcr.io if a customer would
like to mirror our image so they can self host behind any proxies or other
custom network stack.
How's this tested?
update,version, and regular commands (dry-run, etc.) should work as normalCONTAINER_REGISTRY=fake.registryvariable in your env file and see that the commands fail (since that registry is fake)docker image tag ghcr.io/actions-importer/cli:latest fake.registry/actions-importer/cli:latestand run a dry-run or other command to see that it worksCloses github/customer-feedback#7007