Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-features, --enable-features, & --disable-features #93

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

Chaseshak
Copy link
Contributor

@Chaseshak Chaseshak commented Mar 28, 2023

What's changing?

  • Adds public facing commands for customers to interact with customer facing feature flags.
  • Note This interface is a little clunky atm, but not many customers use --features atm. There is follow-up work to investigate storing this in a credentials file and/or as env variables.

How's this tested?

  • Specs
  • Running some commands locally:
    • Note You will need to pull the latest docker image before running these commands
    • dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- list-features
    • dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- dry-run circle-ci -o tmp/circle --source-file-path tmp/config.yml --circle-ci-project rails-demo --disable-features=workflow-concurrency-option-allowed actions/cache
      • This should result in an output file that comments out the caching actions syntax

Here's a circle CI config you can use for testing:

version: 2.1

orbs:
  ruby: circleci/ruby@1.1.0
  node: circleci/node@2

jobs:
  build:
    docker:
      - image: cimg/ruby:2.7.5-node
    steps:
      - checkout
      - ruby/install-deps
      # Store bundle cache
      - node/install-packages:
          pkg-manager: yarn
          cache-key: "yarn.lock"

workflows:
  version: 2
  build_and_test:
    jobs:
      - build

Closes github/valet#5714

@Chaseshak Chaseshak force-pushed the add-new-feature-flag-command-and-options branch from a9e46af to 4318d34 Compare March 28, 2023 22:05
@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Unit Test Results

35 tests  ±0   35 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 08769b4. ± Comparison against base commit 90515cb.

♻️ This comment has been updated with latest results.

@Chaseshak Chaseshak marked this pull request as ready for review March 28, 2023 22:07
@Chaseshak Chaseshak requested a review from a team as a code owner March 28, 2023 22:07
src/ActionsImporter/Commands/ListFeatures.cs Outdated Show resolved Hide resolved
…ter)

Co-authored-by: Ethan Dennis <ethanis@github.com>
@Chaseshak Chaseshak force-pushed the add-new-feature-flag-command-and-options branch from da49a6b to 6723575 Compare March 29, 2023 21:16
@Chaseshak Chaseshak merged commit 8d75293 into main Mar 30, 2023
@Chaseshak Chaseshak deleted the add-new-feature-flag-command-and-options branch March 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants