Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake version into binaries to match release version #66

Closed
dylan-smith opened this issue Oct 22, 2021 · 0 comments · Fixed by #88
Closed

Bake version into binaries to match release version #66

dylan-smith opened this issue Oct 22, 2021 · 0 comments · Fixed by #88

Comments

@dylan-smith
Copy link
Collaborator

When building the artifacts to publish a new release, we're not baking the version number (from the release/tag) into the binary. So when you do octoshift --version it will always show 1.0.0.

In old .net this would be done by updating the assemblyinfo.cs files, can't remember how it's done in .Net core.

@dylan-smith dylan-smith linked a pull request Oct 30, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant