Changlog table comment #1138
Merged
Changlog table comment #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm-2
approved these changes
Jul 7, 2022
RainbowDashy
pushed a commit
to RainbowDashy/gh-ost
that referenced
this pull request
Jul 13, 2022
Changlog table comment
d-bytebase
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Jul 13, 2022
* Merge pull request github#1137 from github/go-mysql-binlog-dead-code Remove unused code in `go/mysql/binlog.go` * Merge pull request github#1138 from github/changlog-table-comment Changlog table comment * Merge pull request github#1145 from timvaillancourt/golang-ci-staticcheck-linter `golang-ci`: enable/fix `staticcheck` lint warnings * Merge pull request github#1146 from github/switch-to-term-package Switch to golang.org/x/term; go mod vendor * chore: go mod tidy; go mod vendor * Merge pull request github#1134 from github/changelog-migrated-state Add `Migrated` changelog event state * Merge pull request github#1147 from timvaillancourt/rm-go-os-process-go Remove unused `go/os/process.go` * Move `.Kill()` func from inspector to `go/mysql` (github#1148) * fix: suppress linter Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1133
Description
This PR adds the table-level comment
gh-ost changlelogto the changelog table, in order to make it easier to find usinginformation_schema.tablesAfter this PR, the following query should find
gh-ostchangelog tables:script/cibuildreturns with no formatting errors, build errors or unit test errors.