Reduce the minimal chunk size from 100 to 10.
#1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurschreiber
force-pushed
the
arthur/reduce-minimal-chunk-size
branch
from
535f372
to
a29188f
Compare
christianlang
approved these changes
Feb 7, 2022
octatone
approved these changes
Feb 7, 2022
dm-2
suggested changes
Feb 7, 2022
There was a problem hiding this comment.
Just one small change - please can you also update the "allowed range" values in the help text in this PR? Thanks!
arthurschreiber
force-pushed
the
arthur/reduce-minimal-chunk-size
branch
from
a29188f
to
997c5b8
Compare
dm-2
approved these changes
Feb 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
We'd like to set the minimum chunk size to a value lower than
100. Copying100rows at a time is fine for tables that have a low average row length, but copying100rows at a time from tables that have a large average row lengths is causing replication lag in our clusters.Description
This PR lowers the minimum
chunk-sizevalue from100to10.script/cibuildreturns with no formatting errors, build errors or unit test errors.