Use switch statements for readability, simplify .NewGoMySQLReader()
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvaillancourt
changed the title
switch statements for readabilityswitch statements for readability, simplify .NewGoMySQLReader()
dm-2
approved these changes
Jul 6, 2022
dm-2
pushed a commit
that referenced
this pull request
Jul 7, 2022
…)` (#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
Open
dm-2
pushed a commit
that referenced
this pull request
Jul 7, 2022
…)` (#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
RainbowDashy
pushed a commit
to RainbowDashy/gh-ost
that referenced
this pull request
Jul 11, 2022
…)` (github#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
d-bytebase
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Jul 13, 2022
* Merge pull request github#1143 from github/codeql-run-on-prs Run CodeQL analysis on PRs * Merge pull request github#1141 from shaohk/fix-two-phase-commit-lost-data_v2 fix(lost data in mysql two-phase commit): lost data in mysql two-phas… * compound pk tests (github#387) * compound pk tests * more details in failure diff * more elaborate test; the pk-ts one consistently fails * Fix merge conflict Co-authored-by: Shlomi Noach <shlomi-noach@github.com> Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use `switch` statements for readability, simplify `.NewGoMySQLReader()` (github#1135) * Use `switch` statements for readability * Simplify initBinlogReader() * Add context/timeout to HTTP throttle check (github#1131) * Add context/timeout to HTTP throttle check * Dont run `.GetThrottleHTTPInterval()` on every loop * Update help message * Var rename * 2022 * Add timeout flag * Add unix/tcp server commands, use ParseInt() for string->int64 * Var rename * Re-check http timeout on every loop iteration * Remove stale comment * Make throttle interval idempotent * var rename * Usage grammar * Make http timeout idempotent too * Parse time.Duration once * Move timeout to NewThrottler * Help update * Set User-Agent header * Re-add newline Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> * Default to `go1.17.11` (github#1136) * Default to go1.17.11 * `go mod vendor` Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> * Cancel any row count queries before attempting to cut over (github#846) * Cancel any row count queries before attempting to cut over Closes github#830. Switches from using `QueryRow` to `QueryRowContext`, and stores a context.CancelFunc in the migration context, which is called to halt any running row count query before beginning the cut over. * Make it threadsafe * Kill the count query on the database side as well * Explicitly grab a connection to run the count, store its connection id * When the query context is canceled, run a `KILL QUERY ?` on that connection id * Rewrite these to use the threadsafe functions, stop exporting the cancel func * Update logger * Update logger Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <shlomi-noach@github.com> Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andrew Mason <amason@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves 2 x blocks of code to use
switchstatements for a bit more clarity, as suggested by thegocriticlinter. Also the.NewGoMySQLReader()func ofgo/binlog/gomysql_reader.gowas simplified (unusederrremoved, etc)This change should result in the exact same behaviour as before
Details:
go/binlog/gomysql_reader.goerrreturnswitchfor binlog event type ingo/binlog/gomysql_reader.goswitchon theCutOverTypefield to pick cutover logicscript/cibuildreturns with no formatting errors, build errors or unit test errors