Fix tokens in inspector logging #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiji163
approved these changes
Dec 8, 2023
RainbowDashy
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Jan 2, 2024
d-bytebase
pushed a commit
to bytebase/gh-ost
that referenced
this pull request
Jan 2, 2024
* Add `focal` build * upgrade codeQL action to v2 * Pin docker image to stretch (github#1324) * pin stretch image * update stretch repo * Update Dockerfile.test * parse binlog timestamp in UTC (github#1322) * upgrade standard library deps (github#1332) * fix: typo (github#1331) Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove stale RELEASE_VERSION file (github#1349) Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Force index in unique key range queries (github#1237) * WIP * Pass entire sql.UniqueKey * newline for limit * Rename var --------- Co-authored-by: meiji163 <meiji163@github.com> * Include git commit in version (github#1347) * Include git commit in version Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Make --version output change less-breaking --------- Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Fix tokens in inspector logging (github#1226) * Cleanup whitespace and comments in SQL query text (github#1246) * Cleanup whitespace in SQL query text * cleanup * Add indent * Update unit tests * Update unit tests, pt 2 * Fix tweaks * Fix merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix `--version` output (github#1352) * Fix `--version` output Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Always fallback version/commit if undef Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> --------- Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Update to `go1.21` (github#1351) * go1.21 + bullseye Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go1.21 + bullseye pt 2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * checkout before setup-go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use golangci-lint 1.54.2 to support go1.21 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * stop using io/ioutil to make linter happy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix typo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Lint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert replica-tests CI to ubuntu 20 due to linker errors Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update ensure-go-installed * use `ubuntu-latest` for `ci` job Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * stretch -> bullseye Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> * Replace deprecated `github.com/satori/go.uuid` lib (github#1354) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add `CODEOWNERS` file to auto-request reviews (github#1350) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy * update test * fix lint --------- Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Rashiq <rashiq@users.noreply.github.com> Co-authored-by: meiji163 <meiji163@github.com> Co-authored-by: guangwu <guoguangwu@magic-shield.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes broken logs in the inspector due to using
this.migrationContext.Log.Warning(...)(with%+vtokens) instead of.Warningf(...)Currently the log lines in question do not format correctly:
script/cibuildreturns with no formatting errors, build errors or unit test errors.