row_event converts timestamps to UTC #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued discussion on #161
This explicitly sets UTC for timestamps read by the
go-mysql
library.Unfortunately when returning timestamp, it is returned as a
string
, just so that it is able to support0000-00-00 00:00:00
.But then it uses the local machine's timezone, converting a real time into string, losing context. Because this is a string, it is not converted back to number when applied as DML event.
This is an attempt to fix that, with local tests already proving well.
cc @dveeden
gofmt
(please avoidgoimports
)./build.sh
./test.sh