Hidden password from /proc/{pid}/cmdline or ps command output #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR [briefly explain what it does]
If the user sets the password with a command-line argument, when gh-ost running, another user can get the password from /proc/{pid}/cmdline file or from
ps
command. It seems to be not secure. Asmysql
client does, it will be more secure to replace the password with several x letters.script/cibuild
returns with no formatting errors, build errors or unit test errors.