Nodejitsu Hook

[dscape]

No description provided.

[technoweenie]

What's this do?

[technoweenie]

NVM: thanks for the docs :) Should get this in today or tomorrow.

[dscape]

""Magically"" deploys applications from github (including running tests if you have travis setup) :)

[technoweenie]

Tests would be awesome, so I can confirm I'm not pushing broken code.

[dscape]

I'll work on that.

Will add them to this pull request

[dscape]

tldr

tests are ready

docs

I've separated our API documentation in a gist:

API documentation of the Nodejitsu Web-hook API

Should I include it in the developer notes section?

integration testing

Added some tests, nothing was broken but couldn't get script/deliver_payload to cooperate. I've tested the API from Github (and Travis) a bunch of times in the flatiron-hello-world-api repository.

If you want to do some integration testing:

npm install jitsu -g
jitsu signup

Then go to http://gimmesomebeta.jit.su and get approved for our beta. Go to flatiron-hello-world-api and fork it. Change the package.json file to have a subdomain and name that you can own as a user. Remove the .travis.yml file to avoid having your deploy ignored. we will read it since it has a webhook set in travis we know we should deploy from there instead.

However I've done this a bunch of times now, it works :)

[technoweenie]

I wouldn't worry about Developer Notes. I think those were used before github-services even kept track of a schema per service in the code. You or someone else that's knowledgeable about nodejitsu should be updating the service. We're unable to provide much support for these 80 or so services, because we don't use or even have heard of a lot of them.

This looks good, thanks.

[dscape]

Sounds great, please let me know when this gets merged so we can get some people testing it with real deployments.

[dscape]

@technoweenie any idea when this will be merged? Would be good to know :)

Thank you

[technoweenie]

All set. Let me know if you have problems.

[dscape]

Thank you, will do!

[dscape]

@technoweenie

I've tested the hook and I get this as authorization:

{
    "accept": "*/*",
    "connection": "close",
    "content-type": "application/x-www-form-urlencoded",
    "authorization": "Basic ZHNjYXBlOg==",
    "content-length": "5444",
    "host": "webhooks.nodejitsu.com"
}

$ echo ZHNjYXBlOg== | base64 -D
dscape:
$

It seems like I'm missing the password dscape:. This might be my fault, just wondering if you have any idea why apparently this is not bubbling up?

Works fine in a regular post-receive url hook.

Any suggestions? Sorry I'm quite a ruby lamer so it's probably my fault.

I'm going to comment the line where this happens so you have visibility to it

edit: tests exist for this use case, guess my tests are wrong too

[dscape]

string :subdomain, :username, :branch 
password :password

This seems like it should work no?