Skip to content
This repository has been archived by the owner on Jan 31, 2019. It is now read-only.

Update Trac instructions. Fix #794. #795

Merged
merged 3 commits into from Feb 21, 2014
Merged

Update Trac instructions. Fix #794. #795

merged 3 commits into from Feb 21, 2014

Conversation

aaugustin
Copy link
Contributor

This commit doesn't touch trac.rb to avoid breaking existing installations of http://github.com/davglass/github-trac. trac-github is recommended for new installations.

This commit doesn't touch trac.rb to avoid breaking existing installations of http://github.com/davglass/github-trac. trac-github is recommended for new installations.
@kdaigle
Copy link
Member

kdaigle commented Feb 14, 2014

Thanks for adding this PR @aaugustin. What do you think about adding a small explanation that like "you shouldn't use this service at all unless you're already using it". Not exactly sure about the copy but I'm trying to figure out how to combat "people don't read" and having a service that you technically shouldn't use.

We might also have to introduce the idea of deprecated services or something. Hmm.

@aaugustin
Copy link
Contributor Author

That's a good point. I've added a commit to clarify that.

1. **Url** is your Trac install's url
2. **Token** (this needs to be the same token you put in your trac.ini installed via the plugin)
If you're currently relying on this service, please consider upgrading to
trac-github. It uses a standard Webhook to provide the same features and it's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very tiny nit: can you change Webhook to webhook? Trying to keep it a non-proper noun. Then this is good to 🚢!

@aaugustin
Copy link
Contributor Author

Fixed.

I'll also update the spelling in trac-github's docs.

@blackland1954
Copy link

Thanks for all the help

@blackland1954
Copy link

Awesome im learn all this as fast as I can ,u been a big help,really appreciate everything

kdaigle added a commit that referenced this pull request Feb 21, 2014
Update Trac instructions. Fix #794.
@kdaigle kdaigle merged commit 8555946 into github:master Feb 21, 2014
@kdaigle
Copy link
Member

kdaigle commented Feb 21, 2014

Awesome! Thanks @aaugustin for this and letting us know about the old Trac integration. 👍 This will go out later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants