-
Notifications
You must be signed in to change notification settings - Fork 83.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX.gitignore additions #1499
OSX.gitignore additions #1499
Conversation
Added __MACOSX folder and missing descriptions.
Thanks, but could you explain what this rule is intended to fix? Is there any documentation? |
Hello! I apologize for the delay in responding to this. Well first of all I added a brief explanation/summary to entries that previously did not have any. Presumably this change is self-explanatory, no pun intended. I couldn't find any explanations for .LSOverride via Google searches, hence why I added "?" as the explanation for that one. (I realize this probably isn't standard procedure but I wasn't sure what else to do there.) Regarding the new entry, "__MACOSX/", it's a very common path on Mac systems with plentiful results if you do a web search for it. It only shows up on non-Mac systems, and is useless for non-Mac systems, hence the ignore entry. It is involved with their handling of compressed archives: |
@arcresu Can we merge this? |
I can't take this in as-is, as the line endings have changed and will regress this rule:
cc @Sduibek |
This might sound stupid, but could you add a .gitignore to the .gitignore repo to normalize line endings? 😆 I mean, talk about meta, but it could work right? |
@vgturtle127 I don't think that will address the problem here, as it's been rather easy to break in the past #804 |
Oh, the problem is simply with the Icon that needs two /r line endings in order to work? We can probably remove that, or I can force the line endings in Notepad++. Are line endings not normalized in this repository? If figured they would all be normalized into Unix format (or /LF as it is sometimes called)? |
No, there is no |
Me being rather lazy, I'd just edit the file on the site and create a new PR... |
@shiftkey I can do that if you want. |
@vgturtle127 let's close this out and start afresh |
@shiftkey So what do you want me to do? 😄 |
@vgturtle127 that'd be great, I've got a lot of other things to review 😁 |
@shiftkey What would be great? 😆 Do you want me to do a PR for all the Mac OS X stuff? |
@vgturtle127 sorry I wasn't clear enough. This is the interesting change from the original PR: # Folder attributes
.DS_Store
+
+# Resource Forks
+__MACOSX/ |
@shiftkey OK, just wanted to make sure I knew what I was doing. 😆 |
Added __MACOSX folder and missing descriptions.