Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new folders #1673

Closed
wants to merge 1 commit into from
Closed

added new folders #1673

wants to merge 1 commit into from

Conversation

garf
Copy link

@garf garf commented Sep 25, 2015

No description provided.

@@ -2,3 +2,13 @@
.env.*.php
.env.php
.env
/node_modules
/.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've bumped up against some rule updates to the JetBrains IDEs - see #1475 for the details.

@shiftkey
Copy link
Member

@gaaarfild apologies for not getting back to this sooner, and thanks for the effort. There's a merge conflict here which will prevent merging once this is ready to merge - are you interested in resolving those conflicts?

Also, as I'm not familiar with the ins and outs of Laravel, I'm wondering if it's worth annotating these rules with comments, to help others understand what the rules are there for. Do you think that's worth doing here?

@shiftkey
Copy link
Member

shiftkey commented Mar 6, 2016

I'm trying to clear out the backlog of PRs here, and given the comments haven't seen a reply I'm going to close this out.

@gaaarfild please let me know if you're interested in working together so this can get merged in.

@shiftkey shiftkey closed this Mar 6, 2016
@garf
Copy link
Author

garf commented Mar 6, 2016

@shiftkey Hi! Sorry for late answer. Was incredibly busy.
I can create one more PR wit updated branch to avoid conflicts,

@shiftkey
Copy link
Member

shiftkey commented Mar 6, 2016

@gaaarfild that'd be great - thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants