Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .jfm extension to visualstudio.gitignore #2028

Closed
wants to merge 1 commit into from
Closed

Add .jfm extension to visualstudio.gitignore #2028

wants to merge 1 commit into from

Conversation

TheBeardedLlama
Copy link

Reasons for making this change:

Changes section of the Team Explorer is listing no changes as git plugin fails terminally because of the presence of the jfm file

Links to documentation supporting these rule changes:

There are none except for this stack overflow question

There is a new file that has appeared recently in the database project directory with extension of jfm.

I have filed a stack overflow question to enquire what this file is, however no one seems to know. Nor is there any mention of it anywhere on MS sites or the tinternet...

I was happy to wait to find out what it is before submitting this PR. However, as of yesterday, it is now breaking the visual studio git plugin leading to no changes being listed in the relevant section in the Team Explorer.

As such, it needs to be added to the VS gitignore to ensure no one else wastes time investigating this issue as I have done.

There is a new file that has appeared recently in the database project directory with extension of jfm.

I have filed a [stack overflow question](http://stackoverflow.com/questions/37704514/visual-studio-2015-database-project-directory-contains-a-file-with-extension-jfm) to enquire what this file is, however no one seems to know. Nor is there any mention of it anywhere on MS sites or the tinternet...

I was happy to wait to find out what it is before submitting this PR. However, as of yesterday, it is now breaking the visual studio git plugin leading to no changes being listed in the relevant section in the Team Explorer.

As such, it needs to be added to the VS gitignore to ensure no one else wastes time investigating this issue as I have done.
@TheBeardedLlama
Copy link
Author

Any idea when this might be merged?

@MurrayFoxcroft
Copy link

Confirmed, this is a problem and *.jfm needs to be included in the visualstudio.gitignore

@taspeotis
Copy link
Contributor

I'm seeing this too. The changes to VisualStudio.gitignore seem correct so IMO this can be merged as soon as possible.

@JimiC
Copy link
Contributor

JimiC commented Aug 6, 2016

I propose this to be moved closer to where *.dbmdl is as it's database project related or even better make a separate section of # Database project files and put there *.dbmdl and *.jfm.
Also requesting the PR to be accepted.

@TheBeardedLlama
Copy link
Author

Happy to move and resubmit if you like.

I'll wait for the moderators to get back to us @JimiC

@shiftkey shiftkey closed this Sep 14, 2016
@taspeotis
Copy link
Contributor

#2104

@TheBeardedLlama TheBeardedLlama deleted the patch-1 branch September 14, 2016 11:08
@accidentaldeveloper
Copy link

@TheBeardedLlama Thanks for putting in the effort around this issue. Resolution (other PR) was a little bizarre, but just glad to see that it got taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants